Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade RustPython #4747

Merged
merged 1 commit into from
May 31, 2023
Merged

Upgrade RustPython #4747

merged 1 commit into from
May 31, 2023

Conversation

MichaReiser
Copy link
Member

@MichaReiser MichaReiser commented May 31, 2023 •
edited
Loading

Summary

Upgrade RustPython to get RustPython/Parser#76

Test Plan

cargo test

@MichaReiser MichaReiser enabled auto-merge (squash) May 31, 2023 08:11
@MichaReiser
Copy link
Member Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@MichaReiser MichaReiser force-pushed the upgrade-rust-python branch from e4e4f04 to e1ccaa0 Compare May 31, 2023 08:16
@MichaReiser MichaReiser added the internal An internal refactor or improvement label May 31, 2023
@MichaReiser MichaReiser merged commit 6c1ff6a into main May 31, 2023
@MichaReiser MichaReiser deleted the upgrade-rust-python branch May 31, 2023 08:26
@github-actions
Copy link
Contributor

github-actions bot commented May 31, 2023 •
edited
Loading

PR Check Results

Ecosystem

✅ ecosystem check detected no changes.

Benchmark

Linux

group                                      main                                   pr
-----                                      ----                                   --
linter/all-rules/large/dataset.py          1.00     14.3±0.14ms     2.8 MB/sec    1.01     14.4±0.08ms     2.8 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.00      3.4±0.01ms     4.9 MB/sec    1.02      3.5±0.03ms     4.8 MB/sec
linter/all-rules/numpy/globals.py          1.00    427.4±3.87µs     6.9 MB/sec    1.00    429.1±1.44µs     6.9 MB/sec
linter/all-rules/pydantic/types.py         1.00      5.9±0.01ms     4.3 MB/sec    1.02      6.0±0.02ms     4.3 MB/sec
linter/default-rules/large/dataset.py      1.00      6.8±0.01ms     6.0 MB/sec    1.03      7.0±0.02ms     5.8 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00   1522.2±3.56µs    10.9 MB/sec    1.01   1542.2±3.33µs    10.8 MB/sec
linter/default-rules/numpy/globals.py      1.00    172.8±1.18µs    17.1 MB/sec    1.01    175.3±1.19µs    16.8 MB/sec
linter/default-rules/pydantic/types.py     1.00      3.1±0.01ms     8.1 MB/sec    1.02      3.2±0.01ms     8.0 MB/sec
parser/large/dataset.py                    1.00      5.2±0.01ms     7.8 MB/sec    1.00      5.2±0.01ms     7.9 MB/sec
parser/numpy/ctypeslib.py                  1.01   1018.1±0.52µs    16.4 MB/sec    1.00   1012.7±5.00µs    16.4 MB/sec
parser/numpy/globals.py                    1.01    105.9±0.53µs    27.9 MB/sec    1.00    104.8±0.20µs    28.2 MB/sec
parser/pydantic/types.py                   1.00      2.2±0.00ms    11.4 MB/sec    1.00      2.2±0.00ms    11.4 MB/sec

Windows

group                                      main                                   pr
-----                                      ----                                   --
linter/all-rules/large/dataset.py          1.00     20.5±0.53ms  2028.8 KB/sec    1.01     20.7±0.60ms  2014.4 KB/sec
linter/all-rules/numpy/ctypeslib.py        1.01      5.2±0.34ms     3.2 MB/sec    1.00      5.2±0.25ms     3.2 MB/sec
linter/all-rules/numpy/globals.py          1.00   596.9±30.50µs     4.9 MB/sec    1.01   602.7±37.42µs     4.9 MB/sec
linter/all-rules/pydantic/types.py         1.00      8.6±0.29ms     3.0 MB/sec    1.04      8.9±0.44ms     2.9 MB/sec
linter/default-rules/large/dataset.py      1.01     10.1±0.36ms     4.0 MB/sec    1.00     10.0±0.39ms     4.1 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.02      2.2±0.12ms     7.7 MB/sec    1.00      2.1±0.07ms     7.9 MB/sec
linter/default-rules/numpy/globals.py      1.01   244.2±16.62µs    12.1 MB/sec    1.00   242.9±10.41µs    12.1 MB/sec
linter/default-rules/pydantic/types.py     1.00      4.7±0.25ms     5.5 MB/sec    1.00      4.7±0.26ms     5.5 MB/sec
parser/large/dataset.py                    1.00      7.9±0.30ms     5.1 MB/sec    1.01      8.1±0.27ms     5.1 MB/sec
parser/numpy/ctypeslib.py                  1.00  1489.1±70.08µs    11.2 MB/sec    1.02  1518.6±62.42µs    11.0 MB/sec
parser/numpy/globals.py                    1.00    151.5±8.40µs    19.5 MB/sec    1.03    156.1±6.95µs    18.9 MB/sec
parser/pydantic/types.py                   1.00      3.5±0.20ms     7.4 MB/sec    1.00      3.5±0.14ms     7.4 MB/sec

konstin pushed a commit that referenced this pull request Jun 13, 2023
@MichaReiser @konstin
Upgrade RustPython (#4747)
7c84515
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
internal An internal refactor or improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MichaReiser